Skip to content

Clean up AppURL, remove legacy origin-url webcomponent#37090

Merged
wxiaoguang merged 5 commits into
go-gitea:mainfrom
wxiaoguang:fix-appurl
Apr 3, 2026
Merged

Clean up AppURL, remove legacy origin-url webcomponent#37090
wxiaoguang merged 5 commits into
go-gitea:mainfrom
wxiaoguang:fix-appurl

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang commented Apr 3, 2026 •
edited
Loading

  1. origin-url was introduced in the past when there was no good framework support to detect current host url
    • It is not needed anymore
    • Removing it makes the code clearer
  2. Separate template helper functions for different templates (web page/mail)
  3. The "AppURL" info is removed from admin config page: it doesn't really help.
    • We already have various app url checks at many places

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 3, 2026
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 3, 2026

No pop-in effects because of iife loading, correct?

silverwind
silverwind reviewed Apr 3, 2026
View reviewed changes
Comment thread web_src/js/webcomponents/origin-url.ts
@wxiaoguang
Copy link
Copy Markdown
Contributor Author

wxiaoguang commented Apr 3, 2026

No pop-in effects because of iife loading, correct?

IMO:

  • before: "no pop-in effect" because the webcomponent is loaded before the html code
  • after: the webcomponent is removed, only static html code

silverwind
silverwind reviewed Apr 3, 2026
View reviewed changes
Comment thread services/context/context_template.go
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2026
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 3, 2026 17:17
@wxiaoguang wxiaoguang merged commit f9f9876 into go-gitea:main Apr 3, 2026
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Apr 3, 2026
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 4, 2026
@zjjhot
Merge branch 'main' into mainzjj
afe90f0 
* main:
  Update `setup-uv` to v8.0.0 (go-gitea#37101)
  Fix various bugs (go-gitea#37096)
  Clean up AppURL, remove legacy origin-url webcomponent (go-gitea#37090)
  Add e2e reaction test, improve accessibility, enable parallel testing (go-gitea#37081)
  Fix various legacy problems (go-gitea#37092)
@wxiaoguang wxiaoguang mentioned this pull request Apr 6, 2026
Merged
@wxiaoguang wxiaoguang deleted the fix-appurl branch April 6, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @silverwind @lunny @GiteaBot